From 28ada80b4ceae521f9d87fea7bdfa83cd94a625d Mon Sep 17 00:00:00 2001 From: "Stanislav N. aka pztrn" Date: Sat, 21 Nov 2020 21:35:06 +0500 Subject: [PATCH] Some nolints. --- fill_value.go | 6 ++++-- sec.go | 1 + sec_test.go | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/fill_value.go b/fill_value.go index e67f346..f2eca63 100644 --- a/fill_value.go +++ b/fill_value.go @@ -1,7 +1,7 @@ package sec import ( - "errors" + "fmt" "reflect" "strconv" ) @@ -144,7 +144,9 @@ func fillValue(element *field, data string) error { element.EnvVar) if options.ErrorsAreCritical { - return errors.New("element for environment variable '" + element.EnvVar + "' isn't a pointer and put into interface") + // Better to say to user what is wrong instead of fighting with linters, so: + // nolint + return fmt.Errorf("element for environment variable '%s' isn't a pointer and put into interface", element.EnvVar) } return nil diff --git a/sec.go b/sec.go index 1b6bd77..6a8fa3a 100644 --- a/sec.go +++ b/sec.go @@ -43,6 +43,7 @@ func Parse(structure interface{}, config *Options) error { log.Printf("Invalid '%s' environment variable data: '%s'. Error: %s", debugFlagEnvName, debugFlagRaw, err.Error()) if options.ErrorsAreCritical { + // nolint return err } } else { diff --git a/sec_test.go b/sec_test.go index 2f5fdc1..2a0c362 100644 --- a/sec_test.go +++ b/sec_test.go @@ -90,8 +90,8 @@ type testStruct1 struct { TestNest testDatas TestNestInterfacePointer interface{} TestNestInterface interface{} - testUnexported string - testUnexportedNest *testDatas + // testUnexported string + // testUnexportedNest *testDatas } type testStructWithMap struct {