From 7165f6eb4aedeef2c28a1ca6c6a62eaae801ebea Mon Sep 17 00:00:00 2001
From: Jeff Becker <jeff@i2p.rocks>
Date: Sat, 9 Sep 2017 11:04:37 -0400
Subject: [PATCH] fixes

---
 .../src/nntpchan/lib/nntp/conn_v1.go          |  2 +-
 .../nntpchand/src/nntpchan/lib/store/fs.go    | 29 ++++++++++++++-----
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/contrib/backends/nntpchand/src/nntpchan/lib/nntp/conn_v1.go b/contrib/backends/nntpchand/src/nntpchan/lib/nntp/conn_v1.go
index a6838ab..36a8090 100644
--- a/contrib/backends/nntpchand/src/nntpchan/lib/nntp/conn_v1.go
+++ b/contrib/backends/nntpchand/src/nntpchan/lib/nntp/conn_v1.go
@@ -885,7 +885,7 @@ func (c *v1Conn) readArticle(newpost bool, hooks EventHooks) (ps PolicyStatus, e
 
 			fpath, err := c.storage.StoreArticle(r, msgid.String(), e.Newsgroup().String())
 			r.Close()
-			if err == nil {
+			if err == nil || err == io.EOF {
 				log.WithFields(log.Fields{
 					"pkg":     "nntp-conn",
 					"msgid":   msgid,
diff --git a/contrib/backends/nntpchand/src/nntpchan/lib/store/fs.go b/contrib/backends/nntpchand/src/nntpchan/lib/store/fs.go
index 83f5e51..7788657 100644
--- a/contrib/backends/nntpchand/src/nntpchan/lib/store/fs.go
+++ b/contrib/backends/nntpchand/src/nntpchan/lib/store/fs.go
@@ -39,6 +39,8 @@ func (fs FilesystemStorage) GetWatermark(newsgroup string) (hi, lo uint64, err e
 	var hdr textproto.MIMEHeader
 	hdr, err = fs.getMetadataForNewsgroup(newsgroup)
 	if err == nil {
+		log.Debugf("hdr = %s", hdr)
+		log.Debugf("hiwater = %s", hdr.Get(HighWaterHeader))
 		hi, err = strconv.ParseUint(hdr.Get(HighWaterHeader), 10, 64)
 		if err == nil {
 			lo, err = strconv.ParseUint(hdr.Get(LowWaterHeader), 10, 64)
@@ -52,21 +54,27 @@ func (fs FilesystemStorage) getMetadataForNewsgroup(newsgroup string) (hdr textp
 	fp := fs.metadataFileForNewsgroup(newsgroup)
 	_, err = os.Stat(fp)
 	if os.IsNotExist(err) {
+		log.Infof("create metadata for %s", newsgroup)
 		f, err = os.OpenFile(fp, os.O_RDWR|os.O_CREATE, 0600)
 		if err == nil {
+			c := textproto.NewConn(f)
 			h := make(textproto.MIMEHeader)
 			h.Set(HighWaterHeader, "0")
-			c := textproto.NewConn(f)
-			for k := range hdr {
+			h.Set(LowWaterHeader, "0")
+			for k := range h {
 				for _, v := range h[k] {
 					err = c.PrintfLine("%s: %s", k, v)
 					if err != nil {
 						c.Close()
+						f.Close()
+						log.Errorf("failed to write metadata file: %s", err)
 						return
 					}
 				}
 			}
+			c.PrintfLine("")
 			c.Close()
+			f.Close()
 		}
 	}
 	f, err = os.OpenFile(fp, os.O_RDWR, 0600)
@@ -74,6 +82,7 @@ func (fs FilesystemStorage) getMetadataForNewsgroup(newsgroup string) (hdr textp
 		c := textproto.NewConn(f)
 		hdr, err = c.ReadMIMEHeader()
 		c.Close()
+		f.Close()
 	}
 	return
 }
@@ -88,7 +97,7 @@ func (fs FilesystemStorage) nextIDForNewsgroup(newsgroup string) (id uint64, err
 		if err == nil {
 			hdr.Set(HighWaterHeader, fmt.Sprintf("%d", id))
 			var f *os.File
-			f, err = os.OpenFile(fs.metadataFileForNewsgroup(newsgroup), os.O_WRONLY, 0600)
+			f, err = os.OpenFile(fs.metadataFileForNewsgroup(newsgroup), os.O_WRONLY|os.O_CREATE, 0600)
 			if err == nil {
 				c := textproto.NewConn(f)
 				for k := range hdr {
@@ -96,11 +105,14 @@ func (fs FilesystemStorage) nextIDForNewsgroup(newsgroup string) (id uint64, err
 						err = c.PrintfLine("%s: %s", k, v)
 						if err != nil {
 							c.Close()
+							f.Close()
 							return
 						}
 					}
 				}
+				c.PrintfLine("")
 				c.Close()
+				f.Close()
 			}
 		}
 	}
@@ -234,13 +246,16 @@ func (fs FilesystemStorage) StoreArticle(r io.Reader, msgid, newsgroup string) (
 				nntpid, err = fs.nextIDForNewsgroup(newsgroup)
 				if err == nil {
 					err = os.Symlink(filepath.Join("..", "..", "articles", msgid), filepath.Join(g, fmt.Sprintf("%d", nntpid)))
+				} else {
+					log.Errorf("invalid metadata for newsgroup: %s", err.Error())
 				}
 				if err != nil {
 					log.WithFields(log.Fields{
-						"pkg":   "fs-store",
-						"msgid": msgid,
-						"group": newsgroup,
-					}).Debug("failed to link article")
+						"pkg":    "fs-store",
+						"msgid":  msgid,
+						"group":  newsgroup,
+						"reason": err.Error(),
+					}).Error("failed to link article")
 				}
 			} else {
 				log.WithFields(log.Fields{